From 8bf7f7a4604527885d0977e6ffcac3058cc0d009 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastiaan?= Date: Mon, 6 Jan 2025 08:33:13 +0100 Subject: [PATCH] ci: add pipeline for code formatting checks (#1239) * Add code formatting checks tesT Fix formatting Fix formatting of scripts * Enable check for .func files * Change commentIdentifier & apply prettier to js * fetch-depth 0 * Rename to validate --- .github/workflows/validate-formatting.yaml | 118 +++++++++++++++++++++ 1 file changed, 118 insertions(+) create mode 100644 .github/workflows/validate-formatting.yaml diff --git a/.github/workflows/validate-formatting.yaml b/.github/workflows/validate-formatting.yaml new file mode 100644 index 000000000..eac0936fd --- /dev/null +++ b/.github/workflows/validate-formatting.yaml @@ -0,0 +1,118 @@ +name: Validate script formatting + +on: + push: + branches: + - main + pull_request: + paths: + - "**/*.sh" + - "**/*.func" + - ".github/workflows/validate-formatting.yaml" + +jobs: + shfmt: + name: Check changed files + runs-on: ubuntu-latest + permissions: + pull-requests: write + + steps: + - name: Checkout code + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Get changed files + id: changed-files + run: | + if ${{ github.event_name == 'pull_request' }}; then + echo "files=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep -E '\.(sh|func)$' | xargs)" >> $GITHUB_OUTPUT + else + echo "files=$(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '\.(sh|func)$' | xargs)" >> $GITHUB_OUTPUT + fi + + - name: Set up Go + if: steps.changed-files.outputs.files != '' + uses: actions/setup-go@v5 + + - name: Install shfmt + if: steps.changed-files.outputs.files != '' + run: | + go install mvdan.cc/sh/v3/cmd/shfmt@latest + echo "$GOPATH/bin" >> $GITHUB_PATH + + - name: Run shfmt + if: steps.changed-files.outputs.files != '' + id: shfmt + run: | + set +e + + shfmt_output=$(shfmt -d ${{ steps.changed-files.outputs.files }}) + if [[ $? -eq 0 ]]; then + exit 0 + else + echo "diff=\"$(echo -n "$shfmt_output" | base64 -w 0)\"" >> $GITHUB_OUTPUT + printf "%s" "$shfmt_output" + exit 1 + fi + + - name: Post comment with results + if: always() && steps.changed-files.outputs.files != '' && github.event_name == 'pull_request' + uses: actions/github-script@v7 + with: + script: | + const result = "${{ job.status }}" === "success" ? "success" : "failure"; + const diff = Buffer.from( + "${{ steps.shfmt.outputs.diff }}", + "base64", + ).toString(); + const issueNumber = context.payload.pull_request + ? context.payload.pull_request.number + : null; + const commentIdentifier = "validate-formatting"; + let newCommentBody = `\n### Script formatting\n\n`; + + if (result === "failure") { + newCommentBody += + ":x: We found issues in the formatting of the following changed files:\n\n\`\`\`diff\n${diff}\n\`\`\`\n"; + } else { + newCommentBody += `:rocket: All changed shell scripts are formatted correctly!\n`; + } + + newCommentBody += `\n\n`; + + if (issueNumber) { + const { data: comments } = await github.rest.issues.listComments({ + ...context.repo, + issue_number: issueNumber, + }); + + const existingComment = comments.find( + (comment) => comment.user.login === "github-actions[bot]", + ); + + if (existingComment) { + if (existingComment.body.includes(commentIdentifier)) { + const re = new RegExp( + String.raw`[\s\S]*?`, + "", + ); + newCommentBody = existingComment.body.replace(re, newCommentBody); + } else { + newCommentBody = existingComment.body + "\n\n---\n\n" + newCommentBody; + } + + await github.rest.issues.updateComment({ + ...context.repo, + comment_id: existingComment.id, + body: newCommentBody, + }); + } else { + await github.rest.issues.createComment({ + ...context.repo, + issue_number: issueNumber, + body: newCommentBody, + }); + } + }