refactor navidrome (#4120)

ct/navidrome.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
-# Copyright (c) 2021-2025 tteck
+# Copyright (c) 2021-2025 community-scripts ORG
-# Author: tteck (tteckster)
+# Author: MickLesk (CanbiZ)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-# Source: https://www.navidrome.org/
+# Source: https://github.com/navidrome/navidrome
 
 APP="Navidrome"
 var_tags="${var_tags:-music}"
@@ -23,27 +23,35 @@ function update_script() {
     header_info
     check_container_storage
     check_container_resources
-    if [[ ! -d /opt/navidrome ]]; then
+    if [[ ! -d /var/lib/navidrome ]]; then
         msg_error "No ${APP} Installation Found!"
         exit
     fi
-    RELEASE=$(curl -fsSL https://api.github.com/repos/navidrome/navidrome/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
+    RELEASE=$(curl -fsSL https://api.github.com/repos/navidrome/navidrome/releases/latest | grep "tag_name" | awk -F '"' '{print $4}')
-    msg_info "Stopping ${APP}"
+    if [[ ! -f /opt/${APP}_version.txt ]]; then touch /opt/${APP}_version.txt; fi
-    systemctl stop navidrome
+    if [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]]; then
-    msg_ok "Stopped Navidrome"
+        msg_info "Stopping Services"
+        systemctl stop navidrome
+        msg_ok "Services Stopped"
 
-    msg_info "Updating to v${RELEASE}"
+        msg_info "Updating ${APP} to ${RELEASE}"
-    cd /opt
+        TMP_DEB=$(mktemp --suffix=.deb)
-curl -fsSL "https://github.com/navidrome/navidrome/releases/download/v${RELEASE}/navidrome_${RELEASE}_linux_amd64.tar.gz" -o "Navidrome.tar.gz"
+        curl -fsSL -o "${TMP_DEB}" "https://github.com/navidrome/navidrome/releases/download/${RELEASE}/navidrome_${RELEASE#v}_linux_amd64.deb"
-    $STD tar -xvzf Navidrome.tar.gz -C /opt/navidrome/
+        $STD apt-get install -y "${TMP_DEB}"
-    chmod +x /opt/navidrome/navidrome
+        echo "${RELEASE}" >/opt/"${APP}_version.txt"
-    msg_ok "Updated ${APP}"
+        msg_ok "Updated Navidrome"
-    rm -rf /opt/Navidrome.tar.gz
 
-    msg_info "Starting ${APP}"
+        msg_info "Starting Services"
-    systemctl start navidrome.service
+        systemctl start navidrome
-    msg_ok "Started ${APP}"
+        msg_ok "Started Services"
-    msg_ok "Updated Successfully"
+
+        msg_info "Cleaning Up"
+        rm -f "${TMP_DEB}"
+        msg_ok "Cleaned"
+        msg_ok "Updated Successfully"
+    else
+        msg_ok "No update required. ${APP} is already at ${RELEASE}"
+    fi
     exit
 }
 

install/navidrome-install.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-# Copyright (c) 2021-2025 tteck
+# Copyright (c) 2021-2025 community-scripts ORG
-# Author: tteck (tteckster)
+# Author: MickLesk (CanbiZ)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-# Source: https://www.navidrome.org/
+# Source: https://github.com/navidrome/navidrome
 
 source /dev/stdin <<<"$FUNCTIONS_FILE_PATH"
 color
@@ -13,67 +13,30 @@ setting_up_container
 network_check
 update_os
 
-msg_info "Installing Dependencies (patience)"
+msg_info "Installing Dependencies (Patience)"
-$STD apt-get install -y ffmpeg
+$STD apt-get install -y \
+    ffmpeg
 msg_ok "Installed Dependencies"
 
 msg_info "Installing Navidrome"
-RELEASE=$(curl -fsSL https://api.github.com/repos/navidrome/navidrome/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
+RELEASE=$(curl -fsSL https://api.github.com/repos/navidrome/navidrome/releases/latest | grep "tag_name" | awk -F '"' '{print $4}')
-install -d -o root -g root /opt/navidrome
+TMP_DEB=$(mktemp --suffix=.deb)
-install -d -o root -g root /var/lib/navidrome
+curl -fsSL -o "${TMP_DEB}" "https://github.com/navidrome/navidrome/releases/download/${RELEASE}/navidrome_${RELEASE#v}_linux_amd64.deb"
-curl -fsSL "https://github.com/navidrome/navidrome/releases/download/v${RELEASE}/navidrome_${RELEASE}_linux_amd64.tar.gz" -o "Navidrome.tar.gz"
+$STD apt-get install -y "${TMP_DEB}"
-$STD tar -xvzf Navidrome.tar.gz -C /opt/navidrome/
+systemctl enable -q --now navidrome
-chown -R root:root /opt/navidrome
+echo "${RELEASE}" >/opt/Navidrome_version.txt
-chmod +x /opt/navidrome/navidrome
-mkdir -p /music
-cat <<EOF >/var/lib/navidrome/navidrome.toml
-MusicFolder = '/music'
-EOF
 msg_ok "Installed Navidrome"
 
-msg_info "Creating Service"
+read -p "Do you want to install filebrowser addon? (y/n) " -n 1 -r
-service_path="/etc/systemd/system/navidrome.service"
+if [[ $REPLY =~ ^[Yy]$ ]]; then
-
+    bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/addon/filebrowser.sh)"
-echo "[Unit]
+fi
-Description=Navidrome Music Server and Streamer compatible with Subsonic/Airsonic
-After=remote-fs.target network.target
-AssertPathExists=/var/lib/navidrome
-
-[Service]
-User=root
-Group=root
-Type=simple
-ExecStart=/opt/navidrome/navidrome --configfile '/var/lib/navidrome/navidrome.toml'
-WorkingDirectory=/var/lib/navidrome
-TimeoutStopSec=20
-KillMode=process
-Restart=on-failure
-DevicePolicy=closed
-NoNewPrivileges=yes
-PrivateTmp=yes
-PrivateUsers=yes
-ProtectControlGroups=yes
-ProtectKernelModules=yes
-ProtectKernelTunables=yes
-RestrictAddressFamilies=AF_UNIX AF_INET AF_INET6
-RestrictNamespaces=yes
-RestrictRealtime=yes
-SystemCallFilter=~@clock @debug @module @mount @obsolete @reboot @setuid @swap
-ReadWritePaths=/var/lib/navidrome
-ProtectSystem=full
-
-[Install]
-WantedBy=multi-user.target" >$service_path
-systemctl daemon-reload
-systemctl enable -q --now navidrome
-
-msg_ok "Created Service"
 
 motd_ssh
 customize
 
 msg_info "Cleaning up"
+rm -f "${TMP_DEB}"
 $STD apt-get -y autoremove
 $STD apt-get -y autoclean
-rm -rf /root/Navidrome.tar.gz
 msg_ok "Cleaned"