From cc46239c2bf82a48da7e2b1bd8864b5ca54cb1f3 Mon Sep 17 00:00:00 2001
From: CanbiZ <47820557+MickLesk@users.noreply.github.com>
Date: Mon, 14 Apr 2025 17:13:12 +0200
Subject: [PATCH] change function

---
 ct/omada.sh | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/ct/omada.sh b/ct/omada.sh
index 81035c2eb..71194eb15 100644
--- a/ct/omada.sh
+++ b/ct/omada.sh
@@ -52,19 +52,20 @@ function update_script() {
     msg_ok "Azul Zulu Java 21 already installed"
   fi
 
-  msg_info "Updating Omada Controller"
-  latest_url=$(curl -fsSL "https://support.omadanetworks.com/en/download/software/omada-controller/" | grep -o 'https://static\.tp-link\.com/upload/software/[^"]*linux_x64[^"]*\.deb' | head -n 1)
-  latest_version=$(basename "$latest_url")
-  if [ -z "${latest_version}" ]; then
-    msg_error "It seems that the server (tp-link.com) might be down. Please try again at a later time."
-    exit
-  fi
-
-  curl -fsSL "${latest_url}" -O
-  export DEBIAN_FRONTEND=noninteractive
-  $STD dpkg -i ${latest_version}
-  rm -rf ${latest_version}
-  msg_ok "Updated Omada Controller"
+msg_info "Updating Omada Controller"
+OMADA_URL=$(curl -fsSL "https://support.omadanetworks.com/en/download/software/omada-controller/" \
+  | grep -o 'https://static\.tp-link\.com/upload/software/[^"]*linux_x64[^"]*\.deb' \
+  | head -n1)
+OMADA_PKG=$(basename "$OMADA_URL")
+if [ -z "$OMADA_PKG" ]; then
+  msg_error "Could not retrieve Omada package – server may be down."
+  exit 1
+fi
+curl -fsSL "$OMADA_URL" -o "$OMADA_PKG"
+export DEBIAN_FRONTEND=noninteractive
+$STD dpkg -i "$OMADA_PKG"
+rm -f "$OMADA_PKG"
+msg_ok "Updated Omada Controller"
 }
 
 start